-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redone #4189, working preview scrolling #11441
base: master
Are you sure you want to change the base?
Conversation
Current keybindings:
|
05e8d71
to
ecd415f
Compare
Co-authored-by: Manos Mertzianis <[email protected]>
ecd415f
to
a69ea1d
Compare
Hi! Thank you for your help. I fixed my mistakes, and now all should work well. My only concern is about keybinding alt-PageUp, because as mentioned before:
In my case alt-PageDown works pretty fine, but alt-PageUp doesn't. But as mentioned above it might be just a limitation on my platform. |
I've tried it, works very well, very welcomed addition ! I hope it will be merged soon :-) |
I am not a fan of using the |
Hi! Thank u for using helix based on my PR. If u find more bugs I will be happy to fix them :) |
@David-Else Using just PageUp or PageDown seems like nice idea. |
Finally redone preview scrolling on current master. Works pretty fine.
I used code from: @Manosmer, and make it work with current version of helix.
Closes #4102